linux-kernel - Re: [PATCH -next] ntb: intel: Make intel_ntb3_peer_db

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190320151728.GA19781@kudzu.us>
Date:   Wed, 20 Mar 2019 11:17:29 -0400
From:   Jon Mason <jdmason@...zu.us>
To:     Yue Haibing <yuehaibing@...wei.com>
Cc:     dave.jiang@...el.com, allenbh@...il.com,
        linux-kernel@...r.kernel.org, linux-ntb@...glegroups.com
Subject: Re: [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static

On Wed, Mar 20, 2019 at 10:08:12PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@...wei.com>
> 
> Fix sparse warning:
> 
> drivers/ntb/hw/intel/ntb_hw_gen3.c:535:5: warning:
>  symbol 'intel_ntb3_peer_db_addr' was not declared. Should it be static?
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Looks good to me.  Added to the ntb branch,

Thanks,
Jon

> ---
>  drivers/ntb/hw/intel/ntb_hw_gen3.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/ntb/hw/intel/ntb_hw_gen3.c b/drivers/ntb/hw/intel/ntb_hw_gen3.c
> index f475b56..c339716 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_gen3.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_gen3.c
> @@ -532,9 +532,9 @@ static int intel_ntb3_mw_set_trans(struct ntb_dev *ntb, int pidx, int idx,
>  	return 0;
>  }
>  
> -int intel_ntb3_peer_db_addr(struct ntb_dev *ntb, phys_addr_t *db_addr,
> -				resource_size_t *db_size,
> -				u64 *db_data, int db_bit)
> +static int intel_ntb3_peer_db_addr(struct ntb_dev *ntb, phys_addr_t *db_addr,
> +				   resource_size_t *db_size,
> +				   u64 *db_data, int db_bit)
>  {
>  	phys_addr_t db_addr_base;
>  	struct intel_ntb_dev *ndev = ntb_ndev(ntb);
> -- 
> 2.7.0
> 
>