linux-kernel - RE: [PATCH -next] ntb: intel: Make intel_ntb3_peer_db

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <112A412BB11A1242B37129D931BCE5348445D71E@fmsmsx117.amr.corp.intel.com>
Date:   Wed, 20 Mar 2019 15:20:43 +0000
From:   "Jiang, Dave" <dave.jiang@...el.com>
To:     Yue Haibing <yuehaibing@...wei.com>,
        "jdmason@...zu.us" <jdmason@...zu.us>,
        "allenbh@...il.com" <allenbh@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-ntb@...glegroups.com" <linux-ntb@...glegroups.com>
Subject: RE: [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static



> -----Original Message-----
> From: Yue Haibing [mailto:yuehaibing@...wei.com]
> Sent: Wednesday, March 20, 2019 7:08 AM
> To: Jiang, Dave <dave.jiang@...el.com>; jdmason@...zu.us;
> allenbh@...il.com
> Cc: linux-kernel@...r.kernel.org; linux-ntb@...glegroups.com; YueHaibing
> <yuehaibing@...wei.com>
> Subject: [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static
> 
> From: YueHaibing <yuehaibing@...wei.com>
> 
> Fix sparse warning:
> 
> drivers/ntb/hw/intel/ntb_hw_gen3.c:535:5: warning:
>  symbol 'intel_ntb3_peer_db_addr' was not declared. Should it be static?

For now yes. Thanks!

Acked-by: Dave Jiang <dave.jiang@...el.com>

> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/ntb/hw/intel/ntb_hw_gen3.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/ntb/hw/intel/ntb_hw_gen3.c
> b/drivers/ntb/hw/intel/ntb_hw_gen3.c
> index f475b56..c339716 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_gen3.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_gen3.c
> @@ -532,9 +532,9 @@ static int intel_ntb3_mw_set_trans(struct ntb_dev
> *ntb, int pidx, int idx,
>  	return 0;
>  }
> 
> -int intel_ntb3_peer_db_addr(struct ntb_dev *ntb, phys_addr_t *db_addr,
> -				resource_size_t *db_size,
> -				u64 *db_data, int db_bit)
> +static int intel_ntb3_peer_db_addr(struct ntb_dev *ntb, phys_addr_t
> *db_addr,
> +				   resource_size_t *db_size,
> +				   u64 *db_data, int db_bit)
>  {
>  	phys_addr_t db_addr_base;
>  	struct intel_ntb_dev *ndev = ntb_ndev(ntb);
> --
> 2.7.0
>