linux-kernel - Re: [PATCH] ELAN touchpad i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeR2ojtEB1gGE6hPiv9gWfLPyop1rsok1NSV57jrVU9zg@mail.gmail.com>
Date:   Wed, 20 Mar 2019 19:11:09 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:     hotwater438@...anota.com, Jiri Kosina <jikos@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Kai Heng Feng <kai.heng.feng@...onical.com>,
        Stephen Boyd <swboyd@...omium.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Dmitry Torokhov <dtor@...omium.org>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ELAN touchpad i2c_hid bugs fix

On Wed, Mar 20, 2019 at 4:38 PM Benjamin Tissoires
<benjamin.tissoires@...hat.com> wrote:
> On Wed, Mar 20, 2019 at 2:28 PM <hotwater438@...anota.com> wrote:

> > Patch is created by help of ELANTECH and RedHat guys (Hans De Goede <hdegoede@...hat.com>, Benjamin Tissoires <btissoir@...hat.com>, Andy Shevchenko <andy.shevchenko@...il.com>) and me (Vladislav Dalechyn <hotwater438@...anota.com>.
>
> Don't take it wrong, but that's not how we give credit in a patch.
> In your case, if you do not have any Elantech engineer who agreed to
> sign off the patch, you can definitively mention them this way.
> But the other guys (Hans, Andy and myself) are well known kernel
> developers in the input and HID subsystems, so we usually take the
> fame by adding our Reviewed-by or Signed-off-by tag at the end of the
> commit message. (Also note that Andy is working for Intel ;-P )
>
> If you feel that these persons have an equal participation in the
> creation of the patch, you should ask for their Signed-off-by in the
> patch. My gut feelings tell me they would gladly give a Reviewed-by
> because they helped you on the patch, but they are not the "author",
> so the Signed-off-by should be you only.

Just in case, we have Co-developed-by: tag and for my opinion Hans'
name should go under this category.

-- 
With Best Regards,
Andy Shevchenko