linux-kernel - Re: [PATCH 2/4] ARM: dts: rockchip: Fix gpu opp node names for rk3288

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190321210813.GR112750@google.com>
Date:   Thu, 21 Mar 2019 14:08:13 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     Heiko Stuebner <heiko@...ech.de>, ryandcase@...omium.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rockchip@...ts.infradead.org,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/4] ARM: dts: rockchip: Fix gpu opp node names for rk3288

On Wed, Mar 20, 2019 at 01:14:00PM -0700, Douglas Anderson wrote:
> The device tree compiler yells like this:
>   Warning (unit_address_vs_reg):
>   /gpu-opp-table/opp@...000000:
>   node has a unit name, but no reg property
> 
> Let's match the cpu opp node names and use a dash.
> 
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
> 
>  arch/arm/boot/dts/rk3288.dtsi | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index e9f454248398..79cd3c53e737 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -1282,27 +1282,27 @@
>  	gpu_opp_table: gpu-opp-table {
>  		compatible = "operating-points-v2";
>  
> -		opp@...000000 {
> +		opp-100000000 {
>  			opp-hz = /bits/ 64 <100000000>;
>  			opp-microvolt = <950000>;
>  		};
> -		opp@...000000 {
> +		opp-200000000 {
>  			opp-hz = /bits/ 64 <200000000>;
>  			opp-microvolt = <950000>;
>  		};
> -		opp@...000000 {
> +		opp-300000000 {
>  			opp-hz = /bits/ 64 <300000000>;
>  			opp-microvolt = <1000000>;
>  		};
> -		opp@...000000 {
> +		opp-400000000 {
>  			opp-hz = /bits/ 64 <400000000>;
>  			opp-microvolt = <1100000>;
>  		};
> -		opp@...000000 {
> +		opp-500000000 {
>  			opp-hz = /bits/ 64 <500000000>;
>  			opp-microvolt = <1200000>;
>  		};
> -		opp@...000000 {
> +		opp-600000000 {
>  			opp-hz = /bits/ 64 <600000000>;
>  			opp-microvolt = <1250000>;
>  		};

Reviewed-by: Matthias Kaehlcke <mka@...omium.org>