linux-kernel - Re: [PATCH RFC 01/14] arm64/mm: Introduce asid_info structure and move asid_generation/asid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad32ff02-a88f-ee8a-3296-f859638d66b9@arm.com>
Date:   Thu, 21 Mar 2019 17:03:08 +0000
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     julien.grall@....com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu
Cc:     christoffer.dall@....com, james.morse@....com,
        marc.zyngier@....com, julien.thierry@....com,
        catalin.marinas@....com, will.deacon@....com
Subject: Re: [PATCH RFC 01/14] arm64/mm: Introduce asid_info structure and
 move asid_generation/asid_map to it

Hi Julien,

On 21/03/2019 16:36, Julien Grall wrote:
> In an attempt to make the ASID allocator generic, create a new structure
> asid_info to store all the information necessary for the allocator.
> 
> For now, move the variables asid_generation and asid_map to the new structure
> asid_info. Follow-up patches will move more variables.
> 
> Note to avoid more renaming aftwards, a local variable 'info' has been
> created and is a pointer to the ASID allocator structure.
> 
> Signed-off-by: Julien Grall <julien.grall@....com>
> ---
>   arch/arm64/mm/context.c | 46 ++++++++++++++++++++++++++--------------------
>   1 file changed, 26 insertions(+), 20 deletions(-)
> 
> diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c
> index 1f0ea2facf24..34db54f1a39a 100644
> --- a/arch/arm64/mm/context.c
> +++ b/arch/arm64/mm/context.c
> @@ -30,8 +30,11 @@
>   static u32 asid_bits;
>   static DEFINE_RAW_SPINLOCK(cpu_asid_lock);
>   
> -static atomic64_t asid_generation;
> -static unsigned long *asid_map;
> +struct asid_info
> +{
> +	atomic64_t	generation;
> +	unsigned long	*map;
> +} asid_info;

Shouldn't this be static ? Rest looks fine.

Cheers
Suzuki