linux-kernel - Re: [PATCH RFC 01/14] arm64/mm: Introduce asid_info structure and move asid_generation/asid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <247efb35-2082-289a-43cf-3342b586b1d8@arm.com>
Date:   Thu, 21 Mar 2019 17:27:40 +0000
From:   Julien Grall <julien.grall@....com>
To:     Suzuki K Poulose <suzuki.poulose@....com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        kvmarm@...ts.cs.columbia.edu
Cc:     christoffer.dall@....com, james.morse@....com,
        marc.zyngier@....com, julien.thierry@....com,
        catalin.marinas@....com, will.deacon@....com
Subject: Re: [PATCH RFC 01/14] arm64/mm: Introduce asid_info structure and
 move asid_generation/asid_map to it

On 3/21/19 5:03 PM, Suzuki K Poulose wrote:
> Hi Julien,

Hi Suzuki,

> On 21/03/2019 16:36, Julien Grall wrote:
>> In an attempt to make the ASID allocator generic, create a new structure
>> asid_info to store all the information necessary for the allocator.
>>
>> For now, move the variables asid_generation and asid_map to the new 
>> structure
>> asid_info. Follow-up patches will move more variables.
>>
>> Note to avoid more renaming aftwards, a local variable 'info' has been
>> created and is a pointer to the ASID allocator structure.
>>
>> Signed-off-by: Julien Grall <julien.grall@....com>
>> ---
>>   arch/arm64/mm/context.c | 46 
>> ++++++++++++++++++++++++++--------------------
>>   1 file changed, 26 insertions(+), 20 deletions(-)
>>
>> diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c
>> index 1f0ea2facf24..34db54f1a39a 100644
>> --- a/arch/arm64/mm/context.c
>> +++ b/arch/arm64/mm/context.c
>> @@ -30,8 +30,11 @@
>>   static u32 asid_bits;
>>   static DEFINE_RAW_SPINLOCK(cpu_asid_lock);
>> -static atomic64_t asid_generation;
>> -static unsigned long *asid_map;
>> +struct asid_info
>> +{
>> +    atomic64_t    generation;
>> +    unsigned long    *map;
>> +} asid_info;
> 
> Shouldn't this be static ? Rest looks fine.

Yes it should be static. I have updated my code.

Thank you for the review!

Cheers,

> 
> Cheers
> Suzuki

-- 
Julien Grall