lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Mar 2019 20:28:49 -0700 From: Andrey Smirnov <andrew.smirnov@...il.com> To: dri-devel@...ts.freedesktop.org Cc: Andrey Smirnov <andrew.smirnov@...il.com>, Archit Taneja <architt@...eaurora.org>, Andrzej Hajda <a.hajda@...sung.com>, Laurent Pinchart <Laurent.pinchart@...asonboard.com>, Tomi Valkeinen <tomi.valkeinen@...com>, Andrey Gusakov <andrey.gusakov@...entembedded.com>, Philipp Zabel <p.zabel@...gutronix.de>, Chris Healy <cphealy@...il.com>, Lucas Stach <l.stach@...gutronix.de>, linux-kernel@...r.kernel.org Subject: [PATCH v2 03/15] drm/bridge: tc358767: Simplify polling in tc_link_training() Replace explicit polling in tc_link_training() with equivalent call to tc_poll_timeout() for simplicity. No functional change intended (not including slightly altered debug output). Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com> Cc: Archit Taneja <architt@...eaurora.org> Cc: Andrzej Hajda <a.hajda@...sung.com> Cc: Laurent Pinchart <Laurent.pinchart@...asonboard.com> Cc: Tomi Valkeinen <tomi.valkeinen@...com> Cc: Andrey Gusakov <andrey.gusakov@...entembedded.com> Cc: Philipp Zabel <p.zabel@...gutronix.de> Cc: Chris Healy <cphealy@...il.com> Cc: Lucas Stach <l.stach@...gutronix.de> Cc: dri-devel@...ts.freedesktop.org Cc: linux-kernel@...r.kernel.org --- drivers/gpu/drm/bridge/tc358767.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 2531f4dadbf8..38d542f553cd 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -733,21 +733,18 @@ static int tc_set_video_mode(struct tc_data *tc, struct drm_display_mode *mode) static int tc_wait_link_training(struct tc_data *tc, u32 *error) { - u32 timeout = 1000; u32 value; int ret; - do { - udelay(1); - tc_read(DP0_LTSTAT, &value); - } while ((!(value & LT_LOOPDONE)) && (--timeout)); - - if (timeout == 0) { + ret = tc_poll_timeout(tc, DP0_LTSTAT, LT_LOOPDONE, + LT_LOOPDONE, 1, 1000); + if (ret) { dev_err(tc->dev, "Link training timeout waiting for LT_LOOPDONE!\n"); - ret = -ETIMEDOUT; goto err; } + tc_read(DP0_LTSTAT, &value); + *error = (value >> 8) & 0x7; return 0; -- 2.20.1
Powered by blists - more mailing lists