linux-kernel - Re: [PATCH] crypto: caam - fix copy of next buffer for xcbc and cmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Mar 2019 12:38:00 +0000
From:   Horia Geanta <horia.geanta@....com>
To:     Iuliana Prodan <iuliana.prodan@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@....com>
CC:     "David S. Miller" <davem@...emloft.net>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH] crypto: caam - fix copy of next buffer for xcbc and cmac

On 3/22/2019 2:12 PM, Iuliana Prodan wrote:
> Fix a side effect of adding xcbc support, when the next_buffer is not
> copied.
> The issue occurs, when there is stored from previous state a blocksize
> buffer and received, a less than blocksize, from user. In this case, the
> nents for req->src is 0, and the next_buffer is not copied.
> An example is:
> {
> 	.tap	= { 17, 15, 8 },
> 	.psize	= 40,
> 	.np	= 3,
> 	.ksize	= 16,
> }
> 
> Cc: <stable@...r.kernel.org>
> Fixes: 12b8567f6fa4 ("crypto: caam - add support for xcbc(aes)")
> Signed-off-by: Iuliana Prodan <iuliana.prodan@....com>
Reviewed-by: Horia Geantă <horia.geanta@....com>

Thanks,
Horia