linux-kernel - Re: [PATCH] crypto: caam - fix copy of next buffer for xcbc and cmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190328060828.7hvcu3qbw7woqwyw@gondor.apana.org.au>
Date:   Thu, 28 Mar 2019 14:08:28 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Iuliana Prodan <iuliana.prodan@....com>
Cc:     Horia Geanta <horia.geanta@....com>,
        Aymen Sghaier <aymen.sghaier@....com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-imx <linux-imx@....com>
Subject: Re: [PATCH] crypto: caam - fix copy of next buffer for xcbc and cmac

On Fri, Mar 22, 2019 at 02:12:30PM +0200, Iuliana Prodan wrote:
> Fix a side effect of adding xcbc support, when the next_buffer is not
> copied.
> The issue occurs, when there is stored from previous state a blocksize
> buffer and received, a less than blocksize, from user. In this case, the
> nents for req->src is 0, and the next_buffer is not copied.
> An example is:
> {
> 	.tap	= { 17, 15, 8 },
> 	.psize	= 40,
> 	.np	= 3,
> 	.ksize	= 16,
> }
> 
> Cc: <stable@...r.kernel.org>
> Fixes: 12b8567f6fa4 ("crypto: caam - add support for xcbc(aes)")
> Signed-off-by: Iuliana Prodan <iuliana.prodan@....com>
> ---
>  drivers/crypto/caam/caamhash.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt