linux-kernel - Re: [PATCH -next] coresight: catu: Make catu_helper_ops and catu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Mar 2019 10:33:57 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Yue Haibing <yuehaibing@...wei.com>
Cc:     "Suzuki K. Poulose" <suzuki.poulose@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH -next] coresight: catu: Make catu_helper_ops and catu_ops static

On Thu, 21 Mar 2019 at 09:19, Yue Haibing <yuehaibing@...wei.com> wrote:
>
> From: YueHaibing <yuehaibing@...wei.com>
>
> Fix sparse warnings:
>
> drivers/hwtracing/coresight/coresight-catu.c:488:35: warning:
>  symbol 'catu_helper_ops' was not declared. Should it be static?
> drivers/hwtracing/coresight/coresight-catu.c:493:28: warning:
>  symbol 'catu_ops' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/hwtracing/coresight/coresight-catu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-catu.c b/drivers/hwtracing/coresight/coresight-catu.c
> index 170fbb6..057627a 100644
> --- a/drivers/hwtracing/coresight/coresight-catu.c
> +++ b/drivers/hwtracing/coresight/coresight-catu.c
> @@ -485,12 +485,12 @@ static int catu_disable(struct coresight_device *csdev, void *__unused)
>         return rc;
>  }
>
> -const struct coresight_ops_helper catu_helper_ops = {
> +static const struct coresight_ops_helper catu_helper_ops = {
>         .enable = catu_enable,
>         .disable = catu_disable,
>  };
>
> -const struct coresight_ops catu_ops = {
> +static const struct coresight_ops catu_ops = {
>         .helper_ops = &catu_helper_ops,
>  };
>

Applied thanks.
Mathieu

> --
> 2.7.0
>
>