linux-kernel - Re: [PATCH -next] selinux: Make selinux_kernfs_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Mar 2019 18:45:59 +0100
From:   Ondrej Mosnacek <omosnace@...hat.com>
To:     Yue Haibing <yuehaibing@...wei.com>
Cc:     Paul Moore <paul@...l-moore.com>,
        Stephen Smalley <sds@...ho.nsa.gov>,
        Eric Paris <eparis@...isplace.org>,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>,
        selinux@...r.kernel.org
Subject: Re: [PATCH -next] selinux: Make selinux_kernfs_init_security static

On Fri, Mar 22, 2019 at 3:04 PM Yue Haibing <yuehaibing@...wei.com> wrote:
> From: YueHaibing <yuehaibing@...wei.com>
>
> Fix sparse warning:
>
> security/selinux/hooks.c:3389:5: warning:
>  symbol 'selinux_kernfs_init_security' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Yup, another trivial mistake on my part...

Acked-by: Ondrej Mosnacek <omosnace@...hat.com>

Thanks for catching that!

> ---
>  security/selinux/hooks.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index ab4b049..b6e6152 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3386,8 +3386,8 @@ static int selinux_inode_copy_up_xattr(const char *name)
>
>  /* kernfs node operations */
>
> -int selinux_kernfs_init_security(struct kernfs_node *kn_dir,
> -                                struct kernfs_node *kn)
> +static int selinux_kernfs_init_security(struct kernfs_node *kn_dir,
> +                                       struct kernfs_node *kn)
>  {
>         const struct task_security_struct *tsec = current_security();
>         u32 parent_sid, newsid, clen;
> --
> 2.7.0

-- 
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.