linux-kernel - Re: [PATCH -next] selinux: Make selinux_kernfs_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhR7eUWxB3Fviqtp5ZUtdjJVasVOdF2MbKTgqufa2vXLdg@mail.gmail.com>
Date:   Fri, 22 Mar 2019 16:02:27 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Yue Haibing <yuehaibing@...wei.com>
Cc:     Stephen Smalley <sds@...ho.nsa.gov>,
        Eric Paris <eparis@...isplace.org>,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>,
        selinux@...r.kernel.org, Ondrej Mosnacek <omosnace@...hat.com>
Subject: Re: [PATCH -next] selinux: Make selinux_kernfs_init_security static

On Fri, Mar 22, 2019 at 1:46 PM Ondrej Mosnacek <omosnace@...hat.com> wrote:
> On Fri, Mar 22, 2019 at 3:04 PM Yue Haibing <yuehaibing@...wei.com> wrote:
> > From: YueHaibing <yuehaibing@...wei.com>
> >
> > Fix sparse warning:
> >
> > security/selinux/hooks.c:3389:5: warning:
> >  symbol 'selinux_kernfs_init_security' was not declared. Should it be static?
> >
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>
> Yup, another trivial mistake on my part...
>
> Acked-by: Ondrej Mosnacek <omosnace@...hat.com>
>
> Thanks for catching that!

Yes, thanks for the patch; I don't always check for static (or
const'ified args) as much as I should when reviewing code.  Merged
into selinux/next.

-- 
paul moore
www.paul-moore.com