linux-kernel - Re: [PATCH v3 3/6] EDAC/amd64: Support more than two Unified Memory Controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190323121546.GA17541@zn.tnic>
Date:   Sat, 23 Mar 2019 13:15:47 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     "Ghannam, Yazen" <Yazen.Ghannam@....com>
Cc:     "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 3/6] EDAC/amd64: Support more than two Unified Memory
 Controllers

On Thu, Feb 28, 2019 at 03:36:10PM +0000, Ghannam, Yazen wrote:
> diff --git a/drivers/edac/amd64_edac.h b/drivers/edac/amd64_edac.h
> index de8dbb0b42b5..40e63cea2d81 100644
> --- a/drivers/edac/amd64_edac.h
> +++ b/drivers/edac/amd64_edac.h
> @@ -274,7 +274,11 @@
>  
>  #define UMC_SDP_INIT			BIT(31)
>  
> -#define NUM_UMCS			2
> +/*
> + * Number of Unified Memory Controllers
> + * Set during driver init based on family/model.
> + */
> +static u8 num_umcs;

Please don't do silly things like that:

In file included from drivers/edac/amd64_edac_inj.c:2:0:
drivers/edac/amd64_edac.h:279:11: warning: ‘num_umcs’ defined but not used [-Wunused-variable]
 static u8 num_umcs;
           ^~~~~~~~

I fixed it up now.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.