linux-kernel - RE: [PATCH v3 3/6] EDAC/amd64: Support more than two Unified Memory Controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 23 Mar 2019 17:22:14 +0000
From:   "Ghannam, Yazen" <Yazen.Ghannam@....com>
To:     Borislav Petkov <bp@...en8.de>
CC:     "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 3/6] EDAC/amd64: Support more than two Unified Memory
 Controllers

> -----Original Message-----
> From: linux-edac-owner@...r.kernel.org <linux-edac-owner@...r.kernel.org> On Behalf Of Borislav Petkov
> Sent: Saturday, March 23, 2019 7:16 AM
> To: Ghannam, Yazen <Yazen.Ghannam@....com>
> Cc: linux-edac@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v3 3/6] EDAC/amd64: Support more than two Unified Memory Controllers
> 
> On Thu, Feb 28, 2019 at 03:36:10PM +0000, Ghannam, Yazen wrote:
> > diff --git a/drivers/edac/amd64_edac.h b/drivers/edac/amd64_edac.h
> > index de8dbb0b42b5..40e63cea2d81 100644
> > --- a/drivers/edac/amd64_edac.h
> > +++ b/drivers/edac/amd64_edac.h
> > @@ -274,7 +274,11 @@
> >
> >  #define UMC_SDP_INIT			BIT(31)
> >
> > -#define NUM_UMCS			2
> > +/*
> > + * Number of Unified Memory Controllers
> > + * Set during driver init based on family/model.
> > + */
> > +static u8 num_umcs;
> 
> Please don't do silly things like that:
> 
> In file included from drivers/edac/amd64_edac_inj.c:2:0:
> drivers/edac/amd64_edac.h:279:11: warning: ‘num_umcs’ defined but not used [-Wunused-variable]
>  static u8 num_umcs;
>            ^~~~~~~~
> 
> I fixed it up now.
> 

Thanks. Sorry I missed that.

-Yazen