linux-kernel - Re: [PATCH] media: usbvision: fix a potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <EF54DB77-D052-4A81-8631-FDB0772F5C70@umn.edu>
Date:   Fri, 22 Mar 2019 22:07:17 -0500
From:   Kangjie Lu <kjlu@....edu>
To:     kjlu@....edu
Cc:     pakki001@....edu, Hans Verkuil <hverkuil@...all.nl>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Colin Ian King <colin.king@...onical.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: usbvision: fix a potential NULL pointer
 dereference



> On Mar 9, 2019, at 1:42 AM, Kangjie Lu <kjlu@....edu> wrote:
> 
> In case usb_alloc_coherent fails, the fix returns -ENOMEM to
> avoid a potential NULL pointer dereference.
> 
> Signed-off-by: Kangjie Lu <kjlu@....edu>
> ---
> drivers/media/usb/usbvision/usbvision-core.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/media/usb/usbvision/usbvision-core.c b/drivers/media/usb/usbvision/usbvision-core.c
> index 31e0e98d6daf..1b0d0a0f0e87 100644
> --- a/drivers/media/usb/usbvision/usbvision-core.c
> +++ b/drivers/media/usb/usbvision/usbvision-core.c
> @@ -2302,6 +2302,9 @@ int usbvision_init_isoc(struct usb_usbvision *usbvision)
> 					   sb_size,
> 					   GFP_KERNEL,
> 					   &urb->transfer_dma);
> +		if (!usbvision->sbuf[buf_idx].data)
> +			return -ENOMEM;
> +

Can someone review this patch?

> 		urb->dev = dev;
> 		urb->context = usbvision;
> 		urb->pipe = usb_rcvisocpipe(dev, usbvision->video_endp);
> -- 
> 2.17.1
>