linux-kernel - Re: [PATCH] memstick: fix a potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <11B50B8B-7A27-4BFD-B0C6-669C74381B46@umn.edu>
Date:   Fri, 22 Mar 2019 22:08:37 -0500
From:   Kangjie Lu <kjlu@....edu>
To:     kjlu@....edu
Cc:     pakki001@....edu, Maxim Levitsky <maximlevitsky@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memstick: fix a potential NULL pointer dereference

Hi Maxim,

Can you review this patch? 

Thanks,

> On Mar 9, 2019, at 1:59 AM, Kangjie Lu <kjlu@....edu> wrote:
> 
> In case alloc_ordered_workqueue fails, the fix returns ENOMEM to
> avoid potential NULL pointer dereference.
> 
> Signed-off-by: Kangjie Lu <kjlu@....edu>
> ---
> drivers/memstick/core/ms_block.c | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c
> index 82daccc9ea62..8e00de414567 100644
> --- a/drivers/memstick/core/ms_block.c
> +++ b/drivers/memstick/core/ms_block.c
> @@ -2149,6 +2149,11 @@ static int msb_init_disk(struct memstick_dev *card)
> 
> 	msb->usage_count = 1;
> 	msb->io_queue = alloc_ordered_workqueue("ms_block", WQ_MEM_RECLAIM);
> +	if (!msb->io_queue) {
> +		rc = -ENOMEM;
> +		goto out_put_disk;
> +	}
> +
> 	INIT_WORK(&msb->io_work, msb_io_work);
> 	sg_init_table(msb->prealloc_sg, MS_BLOCK_MAX_SEGS+1);
> 
> -- 
> 2.17.1
>