linux-kernel - Re: [PATCH] mfd: fix a potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <C71F9E7E-5EF8-4AE5-92D4-4596D25B1D9B@umn.edu>
Date:   Fri, 22 Mar 2019 22:09:47 -0500
From:   Kangjie Lu <kjlu@....edu>
To:     kjlu@....edu
Cc:     pakki001@....edu, Lee Jones <lee.jones@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: fix a potential NULL pointer dereference

Hi Lee Jones,

Can you review this patch?

Thanks. 

> On Mar 9, 2019, at 2:04 AM, Kangjie Lu <kjlu@....edu> wrote:
> 
> In case devm_kzalloc fails, the fix does NULL check and returns
> -ENOMEM upon failure so as to avoid NULL pointer dereference.
> 
> Signed-off-by: Kangjie Lu <kjlu@....edu>
> ---
> drivers/mfd/sm501.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
> index a530972c5a7e..e0173bf4b0dc 100644
> --- a/drivers/mfd/sm501.c
> +++ b/drivers/mfd/sm501.c
> @@ -1145,6 +1145,9 @@ static int sm501_register_gpio_i2c_instance(struct sm501_devdata *sm,
> 	lookup = devm_kzalloc(&pdev->dev,
> 			      sizeof(*lookup) + 3 * sizeof(struct gpiod_lookup),
> 			      GFP_KERNEL);
> +	if (!lookup)
> +		return -ENOMEM;
> +
> 	lookup->dev_id = "i2c-gpio";
> 	if (iic->pin_sda < 32)
> 		lookup->table[0].chip_label = "SM501-LOW";
> -- 
> 2.17.1
>