linux-kernel - Re: [GIT PULL] auxdisplay for v5.1-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72kYJoeY=VqAG82-XNX5d_FoMkHHNtXO+-n0fsy-zif4og@mail.gmail.com>
Date:   Sun, 24 Mar 2019 23:01:44 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mans Rullgard <mans@...sr.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Ksenija Stanojevic <ksenija.stanojevic@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] auxdisplay for v5.1-rc2

Hi Linus,

On Sun, Mar 24, 2019 at 10:10 PM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> Side note: this is very annoying. As part of the rc release I'm going
> through things like this, and I notice that the new Kconfig option has
> absolutely no help text.
>
> That might be acceptable if the choice of options made sense and would
> be obvious to people, but they aren't obvious. Particularly not when
> you come from not having an option at all, it's not at all clear that
> what _used_ to happen was that "flash" option.
>
> And yes, the Kconfig source code makes it look like there are help
> texts. But a help text on the individual options for a choice isn't
> actually shown when you ask for help - it's the help text for the
> *choice* that matters. Not that those invisible help texts actually
> _help_ anything anyway.

The help on the actual option is a good point; we will add it. Also
the Kconfig in general needs a bit of love, I think.

Thanks a lot for taking a look, by the way!

Cheers,
Miguel