linux-kernel - Re: [PATCH 2/4] x86, putuser: copy pasta into 32 and 64-bit versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190324215101.GL23289@zn.tnic>
Date:   Sun, 24 Mar 2019 22:51:01 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] x86, putuser: copy pasta into 32 and 64-bit versions

On Sun, Mar 17, 2019 at 12:02:39AM +0300, Alexey Dobriyan wrote:
> I'm going to rewrite 64-bit version to use normal x86_64 calling convention.

This commit message is too laconic and it needs to be in passive voice
and impartial. Also, here or in your 4/4 I'm missing the justification
for why you're doing all this.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.