lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 24 Mar 2019 18:21:10 -0500
From:   Kangjie Lu <kjlu@....edu>
To:     kjlu@....edu
Cc:     pakki001@....edu, Olli Salonen <olli.salonen@....fi>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] media: tuners: fix a missing check for regmap_write_bits

regmap_write_bits could fail and thus deserves a check.

The fix returns its error code upstream in case it fails.

Signed-off-by: Kangjie Lu <kjlu@....edu>
---
 drivers/media/tuners/tda18250.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/tuners/tda18250.c b/drivers/media/tuners/tda18250.c
index 20d10ef45ab6..36ede1b02d23 100644
--- a/drivers/media/tuners/tda18250.c
+++ b/drivers/media/tuners/tda18250.c
@@ -703,6 +703,8 @@ static int tda18250_set_params(struct dvb_frontend *fe)
 
 	/* charge pump */
 	ret = regmap_write_bits(dev->regmap, R46_CPUMP, 0x07, buf[2]);
+	if (ret)
+		goto err;
 
 	return 0;
 err:
-- 
2.17.1

Powered by blists - more mailing lists