linux-kernel - Re: [PATCH] media: tuners: fix a missing check for regmap_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2cac6391-c328-873c-2cc4-f20b4643e0d7@codeaurora.org>
Date:   Wed, 27 Mar 2019 20:42:32 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Kangjie Lu <kjlu@....edu>
Cc:     pakki001@....edu, Olli Salonen <olli.salonen@....fi>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: tuners: fix a missing check for regmap_write_bits


On 3/25/2019 4:51 AM, Kangjie Lu wrote:
> regmap_write_bits could fail and thus deserves a check.
>
> The fix returns its error code upstream in case it fails.
>
> Signed-off-by: Kangjie Lu <kjlu@....edu>
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

-Mukesh
> ---
>   drivers/media/tuners/tda18250.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/tuners/tda18250.c b/drivers/media/tuners/tda18250.c
> index 20d10ef45ab6..36ede1b02d23 100644
> --- a/drivers/media/tuners/tda18250.c
> +++ b/drivers/media/tuners/tda18250.c
> @@ -703,6 +703,8 @@ static int tda18250_set_params(struct dvb_frontend *fe)
>   
>   	/* charge pump */
>   	ret = regmap_write_bits(dev->regmap, R46_CPUMP, 0x07, buf[2]);
> +	if (ret)
> +		goto err;
>   
>   	return 0;
>   err: