[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190404200907.3fet563fmagpdh6w@gofer.mess.org>
Date: Thu, 4 Apr 2019 21:09:08 +0100
From: Sean Young <sean@...s.org>
To: Kangjie Lu <kjlu@....edu>
Cc: pakki001@....edu, Olli Salonen <olli.salonen@....fi>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: tuners: fix a missing check for regmap_write_bits
On Sun, Mar 24, 2019 at 06:21:10PM -0500, Kangjie Lu wrote:
> regmap_write_bits could fail and thus deserves a check.
>
> The fix returns its error code upstream in case it fails.
Has this been tested on real hardware?
Sean
>
> Signed-off-by: Kangjie Lu <kjlu@....edu>
> ---
> drivers/media/tuners/tda18250.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/tuners/tda18250.c b/drivers/media/tuners/tda18250.c
> index 20d10ef45ab6..36ede1b02d23 100644
> --- a/drivers/media/tuners/tda18250.c
> +++ b/drivers/media/tuners/tda18250.c
> @@ -703,6 +703,8 @@ static int tda18250_set_params(struct dvb_frontend *fe)
>
> /* charge pump */
> ret = regmap_write_bits(dev->regmap, R46_CPUMP, 0x07, buf[2]);
> + if (ret)
> + goto err;
>
> return 0;
> err:
> --
> 2.17.1
Powered by blists - more mailing lists