linux-kernel - Re: [PATCH -next] ASoC: simple-card-utils: remove set but not used variable ''

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae41e273-1c0e-c178-cc94-7f0330b7559f@huawei.com>
Date:   Mon, 25 Mar 2019 15:58:04 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Mukesh Ojha <mojha@...eaurora.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        "Takashi Iwai" <tiwai@...e.com>,
        Katsuhiro Suzuki <suzuki.katsuhiro@...ionext.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
CC:     <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH -next] ASoC: simple-card-utils: remove set but not used
 variable ''

On 2019/3/25 15:42, Mukesh Ojha wrote:
> 
> On 3/23/2019 7:38 AM, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
>> sound/soc/generic/simple-card-utils.c:164:18: warning:
>>   parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
>>
>> It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
> 
> 
> I am not able to find this commit
> 
> 0580dde59438

It's now in linux-next tree.

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=0580dde59438686d60762b6da9229ebec693b94f

> 
> 
>> asoc_simple_debug_info()"), so can be removed.
>>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>>   sound/soc/generic/simple-card-utils.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
>> index 4ed68348f939..db1458a19985 100644
>> --- a/sound/soc/generic/simple-card-utils.c
>> +++ b/sound/soc/generic/simple-card-utils.c
>> @@ -173,10 +173,8 @@ int asoc_simple_parse_clk(struct device *dev,
>>        * see
>>        *    soc-core.c :: snd_soc_init_multicodec()
>>        */
>> -    if (dlc) {
>> +    if (dlc)
>>           dai_of_node    = dlc->of_node;
>> -        dai_name    = dlc->dai_name;
> 
> I don't see any function like `asoc_simple_parse_clk`
> 
> but instead this `asoc_simple_card_parse_clk` and there the variable is used.
> 
> Can you double check latest code base ?
> 
> Thanks,
> Mukesh
> 
> 
>> -    }
>>         /*
>>        * Parse dai->sysclk come from "clocks = <&xxx>"
>>
>>
>>
>>
>>
> 
> .
>