linux-kernel - Re: [PATCH v2 -next] ASoC: simple-card-utils: remove set but not used variable 'dai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4611a8ee-4e89-b871-5151-588bd639a47d@codeaurora.org>
Date:   Wed, 27 Mar 2019 20:23:17 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     YueHaibing <yuehaibing@...wei.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Katsuhiro Suzuki <suzuki.katsuhiro@...ionext.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2 -next] ASoC: simple-card-utils: remove set but not used
 variable 'dai_name'


On 3/25/2019 8:47 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
> sound/soc/generic/simple-card-utils.c:164:18: warning:
>   parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
>
> It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
> asoc_simple_debug_info()"), so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

-Mukesh
> ---
> v2: fix patch title
> ---
>   sound/soc/generic/simple-card-utils.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
> index 4ed68348f939..db1458a19985 100644
> --- a/sound/soc/generic/simple-card-utils.c
> +++ b/sound/soc/generic/simple-card-utils.c
> @@ -173,10 +173,8 @@ int asoc_simple_parse_clk(struct device *dev,
>   	 * see
>   	 *	soc-core.c :: snd_soc_init_multicodec()
>   	 */
> -	if (dlc) {
> +	if (dlc)
>   		dai_of_node	= dlc->of_node;
> -		dai_name	= dlc->dai_name;
> -	}
>   
>   	/*
>   	 * Parse dai->sysclk come from "clocks = <&xxx>"
>
>
>