linux-kernel - Re: [PATCH] net: dccp: Checksum verification considering skb->ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190324.201357.1580092867848179795.davem@davemloft.net>
Date:   Sun, 24 Mar 2019 20:13:57 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     Markus.Amend@...ekom.de
Cc:     gerrit@....abdn.ac.uk, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, dccp@...r.kernel.org
Subject: Re: [PATCH] net: dccp: Checksum verification considering
 skb->ip_summed

From: <Markus.Amend@...ekom.de>
Date: Fri, 22 Mar 2019 14:34:58 +0000

> @@ -786,7 +787,8 @@ static int dccp_v4_rcv(struct sk_buff *skb)
>  
>  	iph = ip_hdr(skb);
>  	/* Step 1: If header checksum is incorrect, drop packet and return */
> -	if (dccp_v4_csum_finish(skb, iph->saddr, iph->daddr)) {
> +	if (__skb_checksum_validate(skb, IPPROTO_DCCP,
> +		  true, false, 0, inet_compute_pseudo)) {

The arguments on the second and subsequent lines of a function call must
begin precisely at the first column after the openning parenthesis of
the first line of the function call.

You must use the appropriate number of TAB, then SPACE, characters
necessary to achieve this.