linux-kernel - Re: [PATCH 1/1] sched/clock: Prevent generic sched_clock wrap caused by tick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1903251449580.1656@nanos.tec.linutronix.de>
Date:   Mon, 25 Mar 2019 14:54:05 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Chang-An Chen <chang-an.chen@...iatek.com>
cc:     Frederic Weisbecker <fweisbec@...il.com>,
        Ingo Molnar <mingo@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Pavel Tatashin <pasha.tatashin@...cle.com>,
        John Stultz <john.stultz@...aro.org>,
        Kees Cook <keescook@...omium.org>,
        Corey Minyard <cminyard@...sta.com>,
        linux-kernel@...r.kernel.org, wsd_upstream@...iatek.com,
        linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        Stanley Chu <stanley.chu@...iatek.com>,
        kuohong.wang@...iatek.com
Subject: Re: [PATCH 1/1] sched/clock: Prevent generic sched_clock wrap caused
 by tick_freeze()

On Mon, 25 Mar 2019, Chang-An Chen wrote:
> --- a/include/linux/sched_clock.h
> +++ b/include/linux/sched_clock.h
> @@ -13,6 +13,10 @@
>  
>  extern void sched_clock_register(u64 (*read)(void), int bits,
>  				 unsigned long rate);
> +
> +extern int sched_clock_suspend(void);
> +
> +extern void sched_clock_resume(void);
>  #else
>  static inline void generic_sched_clock_init(void) { }
>  
> @@ -20,6 +24,10 @@ static inline void sched_clock_register(u64 (*read)(void), int bits,
>  					unsigned long rate)
>  {
>  }
> +
> +static int sched_clock_suspend(void) { }

static inline ...

> +
> +static void sched_clock_resume(void) { }

Ditto

>  #endif

Please do not expose this in the global header. All of this is local to
kernel/time/. So adding this to kernel/time/timekeeping.h is sufficient.

Thanks,

	tglx