linux-kernel - Re: [PATCH 1/1] sched/clock: Prevent generic sched_clock wrap caused by tick_freeze()

Open Source and information security mailing list archives

Message-ID: <1553826609.8188.0.camel@mtkswgap22>
Date:   Fri, 29 Mar 2019 10:30:09 +0800
From:   Chang-An Chen <chang-an.chen@...iatek.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     Corey Minyard <cminyard@...sta.com>,
        Kees Cook <keescook@...omium.org>,
        "wsd_upstream@...iatek.com" <wsd_upstream@...iatek.com>,
        "Frederic Weisbecker" <fweisbec@...il.com>,
        Kuohong Wang (王國鴻) 
        <kuohong.wang@...iatek.com>,
        Pavel Tatashin <pasha.tatashin@...cle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        John Stultz <john.stultz@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Stanley Chu (朱原陞) 
        <stanley.chu@...iatek.com>, Ingo Molnar <mingo@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/1] sched/clock: Prevent generic sched_clock wrap
 caused by tick_freeze()

On Mon, 2019-03-25 at 21:54 +0800, Thomas Gleixner wrote:
> On Mon, 25 Mar 2019, Chang-An Chen wrote:
> > --- a/include/linux/sched_clock.h
> > +++ b/include/linux/sched_clock.h
> > @@ -13,6 +13,10 @@
> >  
> >  extern void sched_clock_register(u64 (*read)(void), int bits,
> >  				 unsigned long rate);
> > +
> > +extern int sched_clock_suspend(void);
> > +
> > +extern void sched_clock_resume(void);
> >  #else
> >  static inline void generic_sched_clock_init(void) { }
> >  
> > @@ -20,6 +24,10 @@ static inline void sched_clock_register(u64 (*read)(void), int bits,
> >  					unsigned long rate)
> >  {
> >  }
> > +
> > +static int sched_clock_suspend(void) { }
> 
> static inline ...
> 
> > +
> > +static void sched_clock_resume(void) { }
> 
> Ditto
> 
> >  #endif
> 
> Please do not expose this in the global header. All of this is local to
> kernel/time/. So adding this to kernel/time/timekeeping.h is sufficient.
Thanks so much for review and the suggestion, I'll fix it in next
version.

Thanks,
Chang-An
> 
> Thanks,
> 
> 	tglx
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives