linux-kernel - Re: [PATCH v4 04/11] tracing: Use tracing error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190325102828.0c778538@gandalf.local.home>
Date:   Mon, 25 Mar 2019 10:28:28 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Tom Zanussi <zanussi@...nel.org>, tglx@...utronix.de,
        mhiramat@...nel.org, bigeasy@...utronix.de, joel@...lfernandes.org,
        linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org
Subject: Re: [PATCH v4 04/11] tracing: Use tracing error_log with trace
 event filters

On Mon, 25 Mar 2019 20:37:23 +0900
Namhyung Kim <namhyung@...nel.org> wrote:

> >  /* Called after a '!' character but "!=" and "!~" are not "not"s */
> >  static bool is_not(const char *str)
> > @@ -947,8 +948,10 @@ static void append_filter_err(struct filter_parse_error *pe,
> >  	if (pe->lasterr > 0) {
> >  		trace_seq_printf(s, "\n%*s", pos, "^");
> >  		trace_seq_printf(s, "\nparse_error: %s\n", err_text[pe->lasterr]);
> > +		tracing_log_err("event filter parse error", filter->filter_string, err_text, pe->lasterr, pe->lasterr_pos);
> >  	} else {
> >  		trace_seq_printf(s, "\nError: (%d)\n", pe->lasterr);
> > +		tracing_log_err("event filter parse error", filter->filter_string, err_text, FILT_ERR_ERRNO, 0);  
> 
> These lines are too long, could you please wrap?

Agreed.


> Otherwise, the whole series look good to me.
> 
> Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks Namhyung!

-- Steve