lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 26 Mar 2019 19:42:18 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     masonccyang@...c.com.tw
Cc:     bbrezillon@...nel.org, broonie@...nel.org,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Simon Horman <horms@...ge.net.au>, juliensu@...c.com.tw,
        linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-spi@...r.kernel.org, marek.vasut@...il.com,
        zhengxunli@...c.com.tw
Subject: Re: [PATCH v8 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller
 driver

On 03/25/2019 10:12 PM, Sergei Shtylyov wrote:

>>>> +static void rpc_spi_mem_set_prep_op_cfg(struct spi_device *spi,
>>>> +               const struct spi_mem_op *op,
>>>> +               u64 *offs, size_t *len)
>>>> +{
>>>> +   struct rpc_spi *rpc = spi_controller_get_devdata(spi->controller);
>>>
>>>> +   if (op->dummy.nbytes) {
>>>> +      rpc->smenr |= RPC_SMENR_DME;
>>>> +      rpc->dummy = RPC_SMDMCR_DMCYC(op->dummy.nbytes);
>>>
>>>    SMDMCR.DMCYC is in bits -- you forgot to multiply by 8.
>>
>> ?
>>
>> It's dummy cycles setting, i.e,. 0 is 1 cycle dummy and
> 
>    Yeah, I should've written "cycles", sorry about that.

   I also should've mentioned that w/o this change the "read SFDP" command
returns garbage and the flash doesn't work.

[...]

MBR, Sergei

Powered by blists - more mailing lists