linux-kernel - Re: [PATCH 14/17] crypto: Don't mark AES tables const and cacheline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190326183003.c6bcy642f5bkf6ry@two.firstfloor.org>
Date:   Tue, 26 Mar 2019 11:30:04 -0700
From:   Andi Kleen <andi@...stfloor.org>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     Andi Kleen <andi@...stfloor.org>, x86@...nel.org,
        akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        Andi Kleen <ak@...ux.intel.com>, herbert@...dor.apana.org.au
Subject: Re: [PATCH 14/17] crypto: Don't mark AES tables const and
 cacheline_aligned

On Tue, Mar 26, 2019 at 09:42:13AM +0100, Rasmus Villemoes wrote:
> On 21/03/2019 23.00, Andi Kleen wrote:
> > From: Andi Kleen <ak@...ux.intel.com>
> > 
> > cacheline_aligned is a special section. It cannot be const at the same
> > time because it's not read-only. It doesn't give any MMU protection.
> 
> Urgh. Perhaps this instead just wanted to use the quadruple underscore
> version, ____cacheline_aligned ? That would make these objects correctly
> aligned and still live in .rodata, no?

Yes that seems to be the right fix.

.rodata is 4K aligned, so it supports 64 bytes too.

-Andi