linux-kernel - Re: [PATCH 8/8] tools/lib/traceevent: remove call to exit() from tep_filter_add_filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Mar 2019 16:02:43 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Tzvetomir Stoyanov <tstoyanov@...are.com>
Cc:     linux-trace-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/8] tools/lib/traceevent: remove call to exit() from
 tep_filter_add_filter_str()

On Tue, 26 Mar 2019 17:43:28 +0200
Tzvetomir Stoyanov <tstoyanov@...are.com> wrote:

> This patch removes call to exit() from tep_filter_add_filter_str(). A library
> function should not force the application to exit. In the current implementation
> tep_filter_add_filter_str() calls exit() when a special "test_filters" mode is
> set, used only for debugging purposes. When this mode is set and a filter is
> added - its string is printed to the console and exit() is called. This patch
> changes the logic - when in "test_filters" mode, the filter string is still
> printed, but the exit() is not called. It is up to the application to track when
> "test_filters" mode is set and to call exit, if needed.

I applied this one too (after changing tep back to pevent so that it
will apply without the other patches).

I'll start testing these and then send them to Arnaldo when complete.

Thanks!

-- Steve

> 
> Signed-off-by: Tzvetomir Stoyanov <tstoyanov@...are.com>
> ---
>  tools/lib/traceevent/parse-filter.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c
> index 298694356277..552592d153fb 100644
> --- a/tools/lib/traceevent/parse-filter.c
> +++ b/tools/lib/traceevent/parse-filter.c
> @@ -1346,9 +1346,6 @@ enum tep_errno tep_filter_add_filter_str(struct tep_event_filter *filter,
>  
>  	free_events(events);
>  
> -	if (rtn >= 0 && tep->test_filters)
> -		exit(0);
> -
>  	return rtn;
>  }
>