linux-kernel - RE: [PATCH v19,RESEND 16/27] x86/sgx: Add the Linux SGX Enclave Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <105F7BF4D0229846AF094488D65A0989356F2FAD@PGSMSX112.gar.corp.intel.com>
Date:   Tue, 26 Mar 2019 21:11:14 +0000
From:   "Huang, Kai" <kai.huang@...el.com>
To:     "Christopherson, Sean J" <sean.j.christopherson@...el.com>,
        "Thomas Gleixner" <tglx@...utronix.de>
CC:     "jarkko.sakkinen@...ux.intel.com" <jarkko.sakkinen@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-sgx@...r.kernel.org" <linux-sgx@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "Svahn, Kai" <kai.svahn@...el.com>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "josh@...htriplett.org" <josh@...htriplett.org>,
        "suresh.b.siddha@...el.com" <suresh.b.siddha@...el.com>,
        "Ayoun, Serge" <serge.ayoun@...el.com>,
        "Huang, Haitao" <haitao.huang@...el.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "npmccallum@...hat.com" <npmccallum@...hat.com>,
        "rientjes@...gle.com" <rientjes@...gle.com>,
        "luto@...nel.org" <luto@...nel.org>,
        "Katz-zamir, Shay" <shay.katz-zamir@...el.com>,
        "Hansen, Dave" <dave.hansen@...el.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>
Subject: RE: [PATCH v19,RESEND 16/27] x86/sgx: Add the Linux SGX Enclave
 Driver

> On Tue, Mar 26, 2019 at 01:40:57PM +0100, Thomas Gleixner wrote:
> > On Tue, 26 Mar 2019, Huang, Kai wrote:
> > > On Wed, 2019-03-20 at 18:21 +0200, Jarkko Sakkinen wrote:
> > > >  13 files changed, 1657 insertions(+), 2 deletions(-)  create mode
> > > > 100644 arch/x86/include/uapi/asm/sgx.h  create mode 100644
> > > > arch/x86/kernel/cpu/sgx/driver/Makefile
> > > >  create mode 100644 arch/x86/kernel/cpu/sgx/driver/driver.h
> > > >  create mode 100644 arch/x86/kernel/cpu/sgx/driver/ioctl.c
> > > >  create mode 100644 arch/x86/kernel/cpu/sgx/driver/main.c
> > > >  create mode 100644 arch/x86/kernel/cpu/sgx/encl.c  create mode
> > > > 100644 arch/x86/kernel/cpu/sgx/encl.h
> > >
> > > Shouldn't the driver be located somewhere under drivers/, but not under
> arch/x86?
> > >
> > > I don't think x86 maintainers should have the burden to review every
> > > code change made to SGX driver?
> >
> > I rather prefer to have it in x86. Why? Because driver code has a
> > tendency to get under the radar.
> 
> And having everything under arch/x86 will likely reduce the maintenance
> burden for everyone:
> 
>    - Doesn't require taking changes through multiple trees or coordinating
>      acks from multiple maintainers.
> 
>    - Significantly reduces the number of functions, macros, structs and
>      variables that needs to be exposed in asm/sgx.h (actually eliminates
>      it entirely at this point) which allows for sane code organization as
>      opposed to dumping everything in one big header.
> 
>    - Mostly avoids bikeshedding over whether something is architectural
>      or belongs in the so called driver.

Sure. Thanks.

Thanks,
-Kai