linux-kernel - Re: [BACKPORT 4.4.y 17/25] mmc: core: don't try to switch block size for dual rate mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190326012731.GA30723@kroah.com>
Date:   Tue, 26 Mar 2019 10:27:31 +0900
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     stable@...r.kernel.org, Ulf Hansson <ulf.hansson@...aro.org>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Avri Altman <avri.altman@....com>,
        Ritesh Harjani <riteshh@...eaurora.org>,
        Jiong Wu <lohengrin1024@...il.com>,
        Martin Hicks <mort@...k.org>,
        Ziyuan Xu <xzy.xu@...k-chips.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [BACKPORT 4.4.y 17/25] mmc: core: don't try to switch block size
 for dual rate mode

On Fri, Mar 22, 2019 at 04:44:08PM +0100, Arnd Bergmann wrote:
> From: Ziyuan Xu <xzy.xu@...k-chips.com>
> 
> Per spec, block size should always be 512 bytes for dual rate mode,
> so any attempts to switch the block size under dual rate mode should
> be neglected.
> 
> Signed-off-by: Ziyuan Xu <xzy.xu@...k-chips.com>
> Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>
> (cherry picked from commit 1712c9373f98ae8ed41599a8d7841a6fba29c264)
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/mmc/core/core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index df074f8c7cb7..3e17268b9994 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -2406,7 +2406,8 @@ int mmc_set_blocklen(struct mmc_card *card, unsigned int blocklen)
>  {
>  	struct mmc_command cmd = {0};
>  
> -	if (mmc_card_blockaddr(card) || mmc_card_ddr52(card))
> +	if (mmc_card_blockaddr(card) || mmc_card_ddr52(card) ||
> +	    mmc_card_hs400(card) || mmc_card_hs400es(card))

This breaks the build, there is no mmc_card_hs400es() call in 4.4.y.

How did this build for you?

greg k-h