linux-kernel - Re: [PATCH] USB/xHCI: Remove returned value 'status' since never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Mar 2019 00:02:04 +0900
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     trivial@...nel.org, Sarah Sharp <sarah.a.sharp@...el.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB/xHCI: Remove returned value 'status' since never used

On Tue, Mar 26, 2019 at 09:15:57PM +0100, Mathieu Malaterre wrote:
> The returned value in status has never been used since
> commit 4296c70a5ec3 ("USB/xHCI: Enable USB 3.0 hub remote wakeup.")
> So remove 'status' completely.
> 
> Remove warning (W=1):
> 
>   drivers/usb/core/hub.c:3671:8: warning: variable 'status' set but not used [-Wunused-but-set-variable]
> 
> Cc: Sarah Sharp <sarah.a.sharp@...el.com>
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> ---
>  drivers/usb/core/hub.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)

Why do you have xhci in your subject line?  Shouldn't it be "USB: hub:"?

Please fix up, thanks.

greg k-h