linux-kernel - Re: [PATCH] USB/xHCI: Remove returned value 'status' since never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Mar 2019 16:51:20 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Mathieu Malaterre <malat@...ian.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     trivial@...nel.org, Sarah Sharp <sarah.a.sharp@...el.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB/xHCI: Remove returned value 'status' since never used


On 3/27/2019 1:45 AM, Mathieu Malaterre wrote:
> The returned value in status has never been used since
> commit 4296c70a5ec3 ("USB/xHCI: Enable USB 3.0 hub remote wakeup.")
> So remove 'status' completely.
>
> Remove warning (W=1):
>
>    drivers/usb/core/hub.c:3671:8: warning: variable 'status' set but not used [-Wunused-but-set-variable]
>
> Cc: Sarah Sharp <sarah.a.sharp@...el.com>
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> ---
>   drivers/usb/core/hub.c | 13 ++++++-------
>   1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 8d4631c81b9f..15a2934dc29d 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -3668,7 +3668,6 @@ static int hub_suspend(struct usb_interface *intf, pm_message_t msg)
>   	struct usb_hub		*hub = usb_get_intfdata(intf);
>   	struct usb_device	*hdev = hub->hdev;
>   	unsigned		port1;
> -	int			status;
>   
>   	/*
>   	 * Warn if children aren't already suspended.
> @@ -3702,12 +3701,12 @@ static int hub_suspend(struct usb_interface *intf, pm_message_t msg)
>   	if (hub_is_superspeed(hdev) && hdev->do_remote_wakeup) {
>   		/* Enable hub to send remote wakeup for all ports. */
>   		for (port1 = 1; port1 <= hdev->maxchild; port1++) {
> -			status = set_port_feature(hdev,
> -					port1 |
> -					USB_PORT_FEAT_REMOTE_WAKE_CONNECT |
> -					USB_PORT_FEAT_REMOTE_WAKE_DISCONNECT |
> -					USB_PORT_FEAT_REMOTE_WAKE_OVER_CURRENT,
> -					USB_PORT_FEAT_REMOTE_WAKE_MASK);


should not we check return value instead of removing it.

Thanks,
Mukesh

> +			set_port_feature(hdev,
> +					 port1 |
> +					 USB_PORT_FEAT_REMOTE_WAKE_CONNECT |
> +					 USB_PORT_FEAT_REMOTE_WAKE_DISCONNECT |
> +					 USB_PORT_FEAT_REMOTE_WAKE_OVER_CURRENT,
> +					 USB_PORT_FEAT_REMOTE_WAKE_MASK);
>   		}
>   	}
>