linux-kernel - Re: [PATCH] net: phy: mdio-bcm-unimac: remove redundant !timeout check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190327.142750.390720588003321523.davem@davemloft.net>
Date:   Wed, 27 Mar 2019 14:27:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: mdio-bcm-unimac: remove redundant !timeout
 check

From: Colin King <colin.king@...onical.com>
Date: Wed, 27 Mar 2019 16:15:20 +0000

> From: Colin Ian King <colin.king@...onical.com>
> 
> The check for zero timeout is always true at the end of the proceeding
> while loop; the only other exit path in the loop is if the unimac MDIO
> is not busy.  Remove the redundant zero timeout check and always
> return -ETIMEDOUT on this timeout return path.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied to net-next.