linux-kernel - Re: [PATCH] net: phy: mdio-bcm-unimac: remove redundant !timeout check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Mar 2019 09:21:23 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Colin King <colin.king@...onical.com>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: mdio-bcm-unimac: remove redundant !timeout
 check

On 3/27/19 9:15 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The check for zero timeout is always true at the end of the proceeding
> while loop; the only other exit path in the loop is if the unimac MDIO
> is not busy.  Remove the redundant zero timeout check and always
> return -ETIMEDOUT on this timeout return path.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian