linux-kernel - Re: [PATCH net-next v5 22/22] ethtool: set message level with SET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f62bd3b-68bb-e0ed-64aa-c0b8399127f9@gmail.com>
Date:   Wed, 27 Mar 2019 20:48:34 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Michal Kubecek <mkubecek@...e.cz>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew@...n.ch>,
        John Linville <linville@...driver.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 22/22] ethtool: set message level with
 SET_SETTINGS request



On 3/25/2019 10:09 AM, Michal Kubecek wrote:
> Allow setting device message level using ETHA_SETTINGS_DEBUG nested
> attribute.
> 
> Unlike in ioctl interface "message level" is called "message mask" (as it
> is in fact used as a bit mask) and put inside a nested attribute to allow
> future extensions.
> 
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian