linux-kernel - Re: [PATCH net-next v5 21/22] ethtool: provide message level in GET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02fb81c1-506c-4116-d4b6-590e27871a00@gmail.com>
Date:   Wed, 27 Mar 2019 20:46:39 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Michal Kubecek <mkubecek@...e.cz>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew@...n.ch>,
        John Linville <linville@...driver.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 21/22] ethtool: provide message level in
 GET_SETTINGS request



On 3/25/2019 10:08 AM, Michal Kubecek wrote:
> Add information about supported and enabled message levels to the
> GET_SETTINGS reply when ETH_SETTINGS_IM_DEBUG flag is set in the
> request.
> 
> Unlike in the ioctl interface, "message level" is called "message mask" as
> it is in fact interpreted as a bit mask. It is put into a nested attribute
> ETHA_SETTINGS_DEBUG to allow future extensions (e.g. an actual verbosity
> level).
> 
> Send notification in the same format as reply when message level is
> modified using the ioctl interface (ETHTOOL_SMSGLVL command).
> 
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian