linux-kernel - RE: [PATCH v2 2/2] arm64: dts: imx8qxp: Add EDMA0/EDMA1 nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM0PR04MB4211FDBE2A19E4FEDEFAF03C80590@AM0PR04MB4211.eurprd04.prod.outlook.com>
Date:   Thu, 28 Mar 2019 09:25:14 +0000
From:   Aisheng Dong <aisheng.dong@....com>
To:     Daniel Baluta <daniel.baluta@...il.com>
CC:     Daniel Baluta <daniel.baluta@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>, Peng Fan <peng.fan@....com>,
        Anson Huang <anson.huang@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "S.j. Wang" <shengjiu.wang@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Teo Hall <teo.hall@....com>, Robin Gong <yibin.gong@....com>
Subject: RE: [PATCH v2 2/2] arm64: dts: imx8qxp: Add EDMA0/EDMA1 nodes

> > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > index 0cb939861a60..84c7c3eca1a1 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > @@ -182,6 +182,78 @@
> > >                       #clock-cells = <1>;
> > >               };
> > >
> > > +             edma0: dma-controller@...f0000 {
> > > +                     compatible = "fsl,imx8qxp-edma";
> > > +                     reg = <0x59200000 0x10000>,   /* asrc0 pair A
> input req */
> > > +                             <0x59210000 0x10000>, /* asrc0 pair B
> input req */
> > > +                             <0x59220000 0x10000>, /* asrc0 pair C
> input req */
> > > +                             <0x59230000 0x10000>, /* asrc0 pair A
> output req */
> > > +                             <0x59240000 0x10000>, /* asrc0 pair B
> output req */
> > > +                             <0x59250000 0x10000>, /* asrc0 pair C
> output req */
> > > +                             <0x59260000 0x10000>, /* esai0 rx */
> > > +                             <0x59270000 0x10000>, /* esai0 tx */
> > > +                             <0x59280000 0x10000>, /* spdif0 rx */
> > > +                             <0x59290000 0x10000>, /* spdif0 tx */
> > > +                             <0x592c0000 0x10000>, /* sai0 rx */
> > > +                             <0x592d0000 0x10000>, /* sai0 tx */
> > > +                             <0x592e0000 0x10000>, /* sai1 rx */
> > > +                             <0x592f0000 0x10000>, /* sai1 tx */
> > > +                     #dma-cells = <3>;
> >
> > In binding doc, it's 2.
> > - #dma-cells : Must be <2>.
> >         The 1st cell specifies the DMAMUX(0 for DMAMUX0 and 1 for
> DMAMUX1).
> >         Specific request source can only be multiplexed by specific
> channels
> >         group called DMAMUX.
> >         The 2nd cell specifies the request source(slot) ID.
> >
> > Need update binding doc?
> >
> > > +                     shared-interrupt;
> >
> > Undocumented property?
> >
> > Checkpatch did not complain?
> 
> Thanks Aisheng for this comment. I think we might need to delay a little bit
> this patch because (as pointed by Yibin) on i.MX8 QXP/QM we use
> fsl-edma-v3 which *is not* yet upstream.
> 
> So, lets get back to adding the nodes after Yibin sends edma-v3 patches.
> 

Yes, Yibin could check the comments when resending with edma driver support.

Regards
Dong Aisheng

> thanks,
> Daniel.