linux-kernel - Re: [RFC PATCH v2 3/7] i2c: core: introduce callbacks for atomic transfers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190329094519.nc2qwpcja3k4e5il@verge.net.au>
Date:   Fri, 29 Mar 2019 10:45:19 +0100
From:   Simon Horman <horms@...ge.net.au>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-i2c@...r.kernel.org, Tero Kristo <t-kristo@...com>,
        Phil Reid <preid@...ctromag.com.au>,
        Tony Lindgren <tony@...mide.com>, Keerthy <j-keerthy@...com>,
        linux-kernel@...r.kernel.org, Russell King <linux@...linux.org.uk>,
        linux-renesas-soc@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-tegra@...r.kernel.org,
        Stefan Lengfeld <contact@...fanchrist.eu>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Peter Rosin <peda@...ntia.se>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [RFC PATCH v2 3/7] i2c: core: introduce callbacks for atomic
 transfers

Hi Wolfram,

On Wed, Mar 27, 2019 at 02:47:51PM +0100, Wolfram Sang wrote:
> Hi Simon,
> 
> please delete unrelated text. I nearly missed the typo fix later.

Ack, will do.

> > > -	if (in_atomic() || irqs_disabled())
> > > +	if (in_atomic() || irqs_disabled()) {
> > > +		WARN(!adap->algo->master_xfer_atomic && !adap->algo->smbus_xfer_atomic,
> > > +		     "No atomic I2C transfer handler for '%s'\n", dev_name(&adap->dev));
> > 
> > 		Is WARN_ONCE more appropriate here?
> 
> Why? It could be multiple adapters or clients causing this?

Good point. I am concerned about the presence of a case which
causes a logging storm.

...