linux-kernel - Re: [PATCH] regulator: vctrl: Remove unneeded continue statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50d35378-9cb4-8b56-9190-0470bf2648f2@codeaurora.org>
Date:   Fri, 29 Mar 2019 16:21:56 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Axel Lin <axel.lin@...ics.com>, Mark Brown <broonie@...nel.org>
Cc:     Matthias Kaehlcke <mka@...omium.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: vctrl: Remove unneeded continue statement


On 3/29/2019 7:16 AM, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@...ics.com>


Yeah indeed! but where is commit text atleast a one-liner.

Otherwise looks good to me.
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
-Mukesh


> ---
>   drivers/regulator/vctrl-regulator.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/vctrl-regulator.c b/drivers/regulator/vctrl-regulator.c
> index 78de002037c7..259864520a06 100644
> --- a/drivers/regulator/vctrl-regulator.c
> +++ b/drivers/regulator/vctrl-regulator.c
> @@ -334,10 +334,8 @@ static int vctrl_init_vtable(struct platform_device *pdev)
>   		ctrl_uV = regulator_list_voltage(ctrl_reg, i);
>   
>   		if (ctrl_uV < vrange_ctrl->min_uV ||
> -		    ctrl_uV > vrange_ctrl->max_uV) {
> +		    ctrl_uV > vrange_ctrl->max_uV)
>   			rdesc->n_voltages--;
> -			continue;
> -		}
>   	}
>   
>   	if (rdesc->n_voltages == 0) {