linux-kernel - Re: [PATCH] regulator: vctrl: Remove unneeded continue statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190329183502.GG112750@google.com>
Date:   Fri, 29 Mar 2019 11:35:02 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Axel Lin <axel.lin@...ics.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: vctrl: Remove unneeded continue statement

Hi Axel,

On Fri, Mar 29, 2019 at 09:46:31AM +0800, Axel Lin wrote:

As Mukesh already mentioned, there should be a short description.

> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/regulator/vctrl-regulator.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/regulator/vctrl-regulator.c b/drivers/regulator/vctrl-regulator.c
> index 78de002037c7..259864520a06 100644
> --- a/drivers/regulator/vctrl-regulator.c
> +++ b/drivers/regulator/vctrl-regulator.c
> @@ -334,10 +334,8 @@ static int vctrl_init_vtable(struct platform_device *pdev)
>  		ctrl_uV = regulator_list_voltage(ctrl_reg, i);
>  
>  		if (ctrl_uV < vrange_ctrl->min_uV ||
> -		    ctrl_uV > vrange_ctrl->max_uV) {
> +		    ctrl_uV > vrange_ctrl->max_uV)
>  			rdesc->n_voltages--;
> -			continue;
> -		}

indeed, the 'continue' is pointless here. I guess at some stage of
development something else was done in the loop and this is a
leftover.

Reviewed-by: Matthias Kaehlcke <mka@...omium.org>