lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 2 Apr 2019 00:04:05 +0800
From:   Tom Li <tomli@...li.me>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     Teddy Wang <teddy.wang@...iconmotion.com>,
        linux-kernel@...r.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 2/7] fbdev: sm712fb: add 2D-related I/O headers and
 functions.

On Sun, Mar 31, 2019 at 06:25:58PM +0100, Sudip Mukherjee wrote:
> On Fri, Mar 22, 2019 at 01:17:54PM +0800, Yifeng Li wrote:
> > +#define DE_CTRL_COMMAND_SHIFT			16
> > +#define DE_CTRL_COMMAND_BITBLT			0x00
> > +#define DE_CTRL_COMMAND_SOLIDFILL		0x01
> > +#define DE_CTRL_COMMAND_HOSTWRITE		0x08
> > +#define DE_CTRL_ROP2_SELECT		0x00008000
> > +#define DE_CTRL_ROP2_SRC_IS_PATTERN	0x00004000
> > +#define DE_CTRL_ROP2_SHIFT			0
> > +#define DE_CTRL_ROP2_COPY			0x0c
> > +#define DE_CTRL_HOST_SHIFT			22
> > +#define DE_CTRL_HOST_SRC_IS_MONO		0x01
> > +#define DE_CTRL_FORMAT_XY			0x00
> > +#define DE_CTRL_FORMAT_24BIT			0x30
> 
> Please fix the alignment. Some of them are right aligned and some are left.

Noted. It will be fixed in PATCH v3.

Thanks,
Tom Li

Powered by blists - more mailing lists