linux-kernel - Re: Potentially missing "memory" clobbers in bitops.h for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190401160406.GE12232@hirez.programming.kicks-ass.net>
Date:   Mon, 1 Apr 2019 18:04:06 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     "Paul E. McKenney" <paulmck@...ux.ibm.com>
Cc:     "H. Peter Anvin" <hpa@...or.com>,
        Alexander Potapenko <glider@...gle.com>,
        Ingo Molnar <mingo@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Dmitriy Vyukov <dvyukov@...gle.com>,
        James Y Knight <jyknight@...gle.com>,
        Will Deacon <will.deacon@....com>
Subject: Re: Potentially missing "memory" clobbers in bitops.h for x86

On Mon, Apr 01, 2019 at 08:44:14AM -0700, Paul E. McKenney wrote:
> On Mon, Apr 01, 2019 at 12:53:48PM +0200, Peter Zijlstra wrote:
> > On Fri, Mar 29, 2019 at 03:05:54PM -0700, Paul E. McKenney wrote:

> > > From Documentation/core-api/atomic_ops.rst:
> > 
> > We should delete that file.
> 
> Only if all of its content is fully present elsewhere.  ;-)

Documentation/atomic_t.txt and Documentation/atomic_bitops.txt _should_
cover all of it I _think_. If there's anything mising, please tell and
we'll write more documents.

And I suppose we should ammend atomic_bitops.txt with a reference to
include/asm-generic/bitops/atomic.h which fully implements the atomic
bitops using atomic_t.