linux-kernel - Re: [PATCH 2/2] ftpm: firmware TPM running in TEE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190402135643.02443863@shemminger-XPS-13-9360>
Date:   Tue, 2 Apr 2019 13:56:43 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     "Sasha Levin" <sashal@...nel.org>
Cc:     <robh+dt@...nel.org>, <mark.rutland@....com>, <peterhuewe@....de>,
        <jarkko.sakkinen@...ux.intel.com>, <jgg@...pe.ca>,
        "Microsoft Linux Kernel List" <linux-kernel@...rosoft.com>,
        "Bryan Kelly (CSI)" <bryankel@...rosoft.com>,
        "Thirupathaiah Annapureddy" <thiruan@...rosoft.com>,
        "Sudhakar Evuri" <suredd@...rosoft.com>, <arnd@...db.de>,
        <gregkh@...uxfoundation.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-integrity@...r.kernel.org>
Subject: Re: [PATCH 2/2] ftpm: firmware TPM running in TEE

On Tue, 2 Apr 2019 12:33:16 -0700
"Sasha Levin" <sashal@...nel.org> wrote:

> +/*
> + * ftpm_tee_tpm_op_recv retrieve fTPM response.
> + * @param: chip, the tpm_chip description as specified in
> driver/char/tpm/tpm.h.
> + * @param: buf,	the buffer to store data.
> + * @param: count, the number of bytes to read.
> + * @return: In case of success the number of bytes received.
> + *	    In other case, a < 0 value describing the issue.
> + */

You are using a docbook style comment but it doesn't start with
docbook prefix.

/**
 * ftpm_tee_tpm_op_recv retrieve fTPM response.
 *
 * @param: chip, the tpm_chip description as specified in driver/char/tpm/tpm.h.
 * @param: buf,	the buffer to store data.
 * @param: count, the number of bytes to read.
 * @return: In case of success the number of bytes received.
 *	    In other case, a < 0 value describing the issue.
 */