linux-kernel - Re: [RFC][PATCH 0/3] tracing: Make error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190402165720.4788e7f8@gandalf.local.home>
Date:   Tue, 2 Apr 2019 16:57:20 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Tom Zanussi <zanussi@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Namhyung Kim <namhyung@...nel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        "Joel Fernandes (Google)" <joel@...lfernandes.org>
Subject: Re: [RFC][PATCH 0/3] tracing: Make error_log per instance

On Tue, 02 Apr 2019 15:42:16 -0500
Tom Zanussi <zanussi@...nel.org> wrote:

> Hi Steve,
> 
> On Tue, 2019-04-02 at 14:29 -0400, Steven Rostedt wrote:
> > Hi Tom,
> > 
> > I noticed that you created an error_log file in every instance, but
> > they all show the same errors. These three patches make it so that
> > the errors appear in the instance directory that they happened in.
> > If you write a bad error to
> > 
> >    /sys/kernel/tracing/instance/foo/events/sched/sched_switch/hist
> > 
> > It appears only in
> > 
> >   /sys/kernel/tracing/instances/foo/error_log
> > 
> > Which I think is the proper approach, especially instances should not
> > affect the top directory or other instances.
> > 
> > For those errors that do not have an associated instance (creating a
> > kprobe/uprobe event or perf), a NULL passed to tracing_log_err() will
> > result in the error message in the top level error message.
> > 
> > Do you (or Masami) have any issues with this patch set?
> > 
> > If not, please add a "reviewed-by" or "acked-by" and I'll add it
> > to your patch series and push them to for-next (after more testing).
> >   
> 
> Looks good, thanks for doing this.  You can add my:
> 
> Reviewed-by: Tom Zanussi <tom.zanussi@...ux.intel.com>
> Tested-by: Tom Zanussi <tom.zanussi@...ux.intel.com>

Thanks, will do.

> 
> FYI, I noticed one bit of trailing whitespace in 2/3 - you might want
> to run it through checkpatch again before you merge ;-)

Hmm, strange that git didn't complain about that. It usually does on a
commit. Or perhaps (more likely) it did, and I didn't notice ;-)

-- Steve