linux-kernel - Re: Warning at drivers/net/wireless/ath/ath10k/mac.c:5625 ath10k_bss_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+ASDXNnRv3AbPqjcsUpfLM+CMSv1CKduRfCUKtZgQ5s8xOPdw@mail.gmail.com>
Date:   Tue, 2 Apr 2019 16:01:46 -0700
From:   Brian Norris <briannorris@...omium.org>
To:     Claire Chang <tientzu@...gle.com>
Cc:     Kalle Valo <kvalo@...eaurora.org>,
        Gabriel C <nix.or.die@...il.com>,
        Paul Menzel <pmenzel@...gen.mpg.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ath10k@...ts.infradead.org,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Sriram R <srirrama@...eaurora.org>,
        Pradeep Kumar Chitrapu <pradeepc@...eaurora.org>
Subject: Re: Warning at drivers/net/wireless/ath/ath10k/mac.c:5625 ath10k_bss_info_changed

+ Rafael
+ authors of these bad commits:
cd93b83ad927 ath10k: support for multicast rate control
f279294e9ee2 ath10k: add support for configuring management packet rate

Hi,

On Mon, Mar 25, 2019 at 8:46 PM Claire Chang <tientzu@...gle.com> wrote:
> On Tue, Mar 26, 2019 at 12:49 AM Brian Norris <briannorris@...omium.org> wrote:
> > On Fri, Mar 8, 2019 at 2:58 AM Kalle Valo <kvalo@...eaurora.org> wrote:
> > > Gabriel C <nix.or.die@...il.com> writes:
> > > > Am Mo., 4. März 2019 um 12:59 Uhr schrieb Kalle Valo <kvalo@...eaurora.org>:
> > > >> Gabriel C <nix.or.die@...il.com> writes:
> > > >> > I reported that twice and no one seems to care about.
> > > >> >
> > > >> > http://lists.infradead.org/pipermail/ath10k/2018-November/012398.html
> > > >> > http://lists.infradead.org/pipermail/ath10k/2018-December/012658.html
> > > >>
> > > >> Does this patch help:
> > > >>
> > > >> ath10k: Drop WARN_ON()s that always trigger during system resume
> > > >>
> > > >> https://patchwork.kernel.org/patch/10837139/
> > > >>
> > > >
> > > > Without to test this patch I can confirm it will help , I dropped the
> > > > WARN_ON()'s in 4.19 already.
> > > > If I remember right 4.19 has one WARN_ON() triggers while 4.20 got two.
> > >
> > > Ok, thanks. I'll try to get this patch to 5.1.
> >
> > Ping? Is there any solution queued anywhere? It's kinda sad how long
> > this has sat here.
> >
> > Brian
>
> Do we need to set mcast rate and basic rates during/after system resume?
> Dropping the WARN_ON() will solve the warning issue, but won't make
> those rates set properly.

I don't think there's anything to fix here about the rate info; the
original patches just made mistakes with how this callback is used. In
this case, we're not associated (we're not using WoWLAN), so it's
ieee80211_reconfig() -> ieee80211_bss_info_change_notify(), which
notifies the current association status (not associated), as well as a
few other parameters. There is no rate info to be had, so we should
just exit silently.

I don't see any reason not to take Rafael's patch. I'll respond with
my Reviewed/Tested there.

Brian