linux-kernel - Re: Warning at drivers/net/wireless/ath/ath10k/mac.c:5625 ath10k_bss_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALiNf2-Wdo4YnKLprUUyPF9QJBL10Mz3wvVG6fWtd_Xi-Yn=6w@mail.gmail.com>
Date:   Tue, 26 Mar 2019 11:46:26 +0800
From:   Claire Chang <tientzu@...gle.com>
To:     Brian Norris <briannorris@...omium.org>
Cc:     Kalle Valo <kvalo@...eaurora.org>,
        Gabriel C <nix.or.die@...il.com>,
        Paul Menzel <pmenzel@...gen.mpg.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ath10k@...ts.infradead.org
Subject: Re: Warning at drivers/net/wireless/ath/ath10k/mac.c:5625 ath10k_bss_info_changed

Hi

On Tue, Mar 26, 2019 at 12:49 AM Brian Norris <briannorris@...omium.org> wrote:
>
> Hi Kalle,
>
> On Fri, Mar 8, 2019 at 2:58 AM Kalle Valo <kvalo@...eaurora.org> wrote:
> > Gabriel C <nix.or.die@...il.com> writes:
> > > Am Mo., 4. März 2019 um 12:59 Uhr schrieb Kalle Valo <kvalo@...eaurora.org>:
> > >> Gabriel C <nix.or.die@...il.com> writes:
> > >> > I reported that twice and no one seems to care about.
> > >> >
> > >> > http://lists.infradead.org/pipermail/ath10k/2018-November/012398.html
> > >> > http://lists.infradead.org/pipermail/ath10k/2018-December/012658.html
> > >>
> > >> Does this patch help:
> > >>
> > >> ath10k: Drop WARN_ON()s that always trigger during system resume
> > >>
> > >> https://patchwork.kernel.org/patch/10837139/
> > >>
> > >
> > > Without to test this patch I can confirm it will help , I dropped the
> > > WARN_ON()'s in 4.19 already.
> > > If I remember right 4.19 has one WARN_ON() triggers while 4.20 got two.
> >
> > Ok, thanks. I'll try to get this patch to 5.1.
>
> Ping? Is there any solution queued anywhere? It's kinda sad how long
> this has sat here.
>
> Brian

Do we need to set mcast rate and basic rates during/after system resume?
Dropping the WARN_ON() will solve the warning issue, but won't make
those rates set properly.