linux-kernel - Re: [PATCH] dccp: Fix memleak in __feat_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190401.181641.1589135999760609672.davem@davemloft.net>
Date:   Mon, 01 Apr 2019 18:16:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     gerrit@....abdn.ac.uk, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, dccp@...r.kernel.org, mojha@...eaurora.org
Subject: Re: [PATCH] dccp: Fix memleak in __feat_register_sp

From: Yue Haibing <yuehaibing@...wei.com>
Date: Mon, 1 Apr 2019 09:35:54 +0800

> From: YueHaibing <yuehaibing@...wei.com>
> 
> If dccp_feat_push_change fails, we forget free the mem
> which is alloced by kmemdup in dccp_feat_clone_sp_val.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values")
> Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied.